Skip to content

Fix JSON field names for vm-configuration and user-data#128427

Merged
v-dirichards merged 1 commit intoMicrosoftDocs:mainfrom
hyperfinitism:guest-attest-patch
Apr 29, 2026
Merged

Fix JSON field names for vm-configuration and user-data#128427
v-dirichards merged 1 commit intoMicrosoftDocs:mainfrom
hyperfinitism:guest-attest-patch

Conversation

@hyperfinitism
Copy link
Copy Markdown
Contributor

The JSON field names of the RuntimeClaims are kebab-case, not snake_case. This PR fixes the JSON names in the table.

@prmerger-automator
Copy link
Copy Markdown
Contributor

@hyperfinitism : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. @Mishih

@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 0850b12:

✅ Validation status: passed

File Status Preview URL Details
articles/confidential-computing/guest-attestation-confidential-virtual-machines-design.md ✅Succeeded

For more details, please refer to the build report.

The JSON field names of the RuntimeClaims are kebab-case, not snake_case.

Signed-off-by: Takuma IMAMURA <[email protected]>
@learn-build-service-prod
Copy link
Copy Markdown
Contributor

Learn Build status updates of commit b9be0c4:

✅ Validation status: passed

File Status Preview URL Details
articles/confidential-computing/guest-attestation-confidential-virtual-machines-design.md ✅Succeeded

For more details, please refer to the build report.

@v-regandowner
Copy link
Copy Markdown
Contributor

@mingweishih

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator Bot added the aq-pr-triaged tracking label for the PR review team label Apr 21, 2026
@mingweishih
Copy link
Copy Markdown
Contributor

#sign-off

@prmerger-automator
Copy link
Copy Markdown
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @Mishih

@v-dirichards v-dirichards requested a review from Copilot April 29, 2026 20:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR updates documentation to reflect that RuntimeClaims JSON field names are kebab-case (not snake_case), correcting the table entries for VM configuration and user data fields.

Changes:

  • Updated vm_configurationvm-configuration in the JSON field table
  • Updated user_datauser-data in the JSON field table

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@v-dirichards
Copy link
Copy Markdown
Contributor

@mingweishih We will merge this PR.

GitHub didn't accept your sign off because your Microsoft alias is listed in both the ms.author and author values. When you have a chance, update the author value with your GitHub alias in the private repo to fix this for the future.

@v-dirichards v-dirichards merged commit 3768fc5 into MicrosoftDocs:main Apr 29, 2026
2 checks passed
@hyperfinitism hyperfinitism deleted the guest-attest-patch branch April 30, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants